Skip to content

Fix performance report template for Bokeh 3.9#9213

Closed
saarantras wants to merge 2 commits intodask:mainfrom
saarantras:fix/perf-report-bokeh39-template
Closed

Fix performance report template for Bokeh 3.9#9213
saarantras wants to merge 2 commits intodask:mainfrom
saarantras:fix/perf-report-bokeh39-template

Conversation

@saarantras
Copy link
Copy Markdown

@saarantras saarantras commented Mar 19, 2026

Related to #9205.

While trying to generate distributed.performance_report logs, I was still hitting a Bokeh 3.9 template error. The compatibility shim added in #9205 fixed the general template rename, but distributed/dashboard/templates/performance_report.html was still extending file.html, which does not exist in Bokeh 3.9's template namespace.

(I have not checked <3.9 Bokeh releases.)

@saarantras saarantras requested a review from fjetter as a code owner March 19, 2026 15:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 19, 2026 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    31 files  ± 0      31 suites  ±0   11h 4m 31s ⏱️ - 13m 12s
 4 115 tests + 1   4 009 ✅ + 1    104 💤 ±0  2 ❌ ±0 
59 663 runs  +15  57 184 ✅ +12  2 477 💤 +3  2 ❌ ±0 

For more details on these failures, see this check.

Results for commit 0ee88b7. ± Comparison against base commit 4182308.

♻️ This comment has been updated with latest results.

@crusaderky crusaderky mentioned this pull request Apr 30, 2026
Merged
@crusaderky
Copy link
Copy Markdown
Collaborator

crusaderky commented Apr 30, 2026 •
edited
Loading

distributed/dashboard/templates/performance_report.html was still extending file.html, which does not exist in Bokeh 3.9's template namespace.

The file is still there in bokeh 3.9; it's just the source URL in the comment that has become obsolete: https://github.com/bokeh/bokeh/blob/main/src/bokeh/core/_templates/file.html

I'm failing to reproduce your issue. Everything seems to work fine for me in the distributed main branch.

Could you provide a minimal reproducer, its output, and the output of conda list / pip freeze?

@crusaderky crusaderky added needs info Needs further information from the user p3 Affects a small number of users or is largely cosmetic labels Apr 30, 2026
@crusaderky crusaderky requested review from crusaderky and removed request for fjetter April 30, 2026 14:34
@saarantras
Copy link
Copy Markdown
Author

saarantras commented Apr 30, 2026

Investigated & it seems this PR is now redundant. I think I built this against an older version, sorry.

@saarantras saarantras closed this Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crusaderky crusaderky Awaiting requested review from crusaderky

Assignees

No one assigned

Labels

needs info Needs further information from the user p3 Affects a small number of users or is largely cosmetic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saarantras @crusaderky